Cast numeric filter values as number for _eq and _neq operators#16657
Merged
rijkvanzanten merged 3 commits intomainfrom Jan 6, 2023
Merged
Cast numeric filter values as number for _eq and _neq operators#16657rijkvanzanten merged 3 commits intomainfrom
rijkvanzanten merged 3 commits intomainfrom
Conversation
br41nslug
approved these changes
Nov 30, 2022
Member
br41nslug
left a comment
There was a problem hiding this comment.
Good fix, works as expected 😄
rijkvanzanten
approved these changes
Jan 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #16649 by allowing equality with the corresponding numeric values.
The filter value in filters are stored in the string format.
For example:
{ "year(updated_on)": { "_eq": "2023" } }Hence when using
_eqwithyear(), it fails validation as2023 !== '2023'.Added checks for
null,""and boolean values as suchNumber(<value>)becomes0.Fixes ENG-126
Type of Change
Requirements Checklist
If adding a new feature: