Remove draft by teoli2003 · Pull Request #1 · dipikabh/content

teoli2003 · 2022-04-04T07:02:38Z

Removing the last few occurrences of {{draft}} \o/

The last steps will be to mark it as deprecated in the meta-docs and update the macro in yari to raise a flaw.

`generateKey` returns a Promise. The variable names (`key` and `keyPair`) seem to indicate that these are actual values, but unawaited they are promises. Adding an await makes that more clear.

* Fix developers.google.com link * Update files/en-us/web/api/console/dir/index.md Co-authored-by: wbamberg <[email protected]> Co-authored-by: wbamberg <[email protected]>

* PWA Add to home icon is now install menu * typo Co-authored-by: wbamberg <[email protected]>

* WebAPI: Clean syntax from property pages, part 11.1 * WebAPI: Clean syntax from property pages, part 11.2

* Fix grammar issue * Update files/en-us/web/api/geolocation/clearwatch/index.md Co-authored-by: Jean-Yves Perrier <[email protected]> Co-authored-by: Jean-Yves Perrier <[email protected]>

…4426)

Arrow functions does not have their own 'this' context. Replacing 'this' with 'volumeSlider' to access value property or we can replace the arrow function with 'function ()' and use 'this' to access value.

* FF98 Remove HTTP Large-Allocation * Apply suggestions from code review Co-authored-by: Ruth John <[email protected]> Co-authored-by: Ruth John <[email protected]>

Correct `timeZoneName` and mention what default value of `timeZone` is.

Bumps [@mdn/yari](https://github.com/mdn/yari) from 0.9.69 to 0.9.71. - [Release notes](https://github.com/mdn/yari/releases) - [Changelog](https://github.com/mdn/yari/blob/main/docs/npm-releases.md) - [Commits](mdn/yari@v0.9.69...v0.9.71) --- updated-dependencies: - dependency-name: "@mdn/yari" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Fix private methods link Add `/` to the private methods link to make it work. * Update files/en-us/web/javascript/closures/index.md Co-authored-by: wbamberg <[email protected]> Co-authored-by: wbamberg <[email protected]>

* Update index.md adapting the module title Because the other modules in this course also always have "CSS" in front of them. * Change just the title not the slug * Change text of links accordingly * Change text of link accordingly

* Rewrites Site definition * Make site definition friendlier * typography Co-authored-by: Daniel D. Beck <[email protected]> * typography Co-authored-by: Daniel D. Beck <[email protected]> * typography Co-authored-by: Daniel D. Beck <[email protected]> * typography Co-authored-by: Daniel D. Beck <[email protected]> Co-authored-by: Will Bamberg <[email protected]> Co-authored-by: Daniel D. Beck <[email protected]>

* Fix developers.google.com link * fix

Co-authored-by: Eric Bailey <[email protected]>

…inks (mdn#14617) * Corrected grammar, punctuation and spelling errors * Fixed broken links

* Replace var with let * Update files/en-us/web/api/document/createelementns/index.md Co-authored-by: Jean-Yves Perrier <[email protected]> Co-authored-by: Jean-Yves Perrier <[email protected]>

* Corrected grammar * Corrected grammar, punctuation and vocabulary * Corrected punctuation and grammar

* Update index.md * Update index.md * Update index.md * Update index.md * Update index.md * Update index.md * Update index.md * Update index.md * Update index.md * Update index.md * Update index.md

* Update index.md * Update index.md * Update index.md

* Replace {{event)}} with domxref * icegatherstatechange * Fix payerdetailchange event.

teoli2003 · 2022-04-04T07:03:21Z

What the hell happened here? Closing this.

teoli2003 · 2022-04-04T07:04:01Z

Argh not in the repo. Sorry Dipika!

* Add `cancel` event https://html.spec.whatwg.org/multipage/indices.html#event-cancel: Fired at dialog elements when they are canceled by the user (e.g., by pressing the Escape key), or at input elements in the File state when the user does not change their selection * 📝 Make linter happy Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * 📝 Add an example * 📝 highlight * 🐛 typo * 📝 Move cancel_event to HTMLElement * 🔥 Removed original HTMLDialogElement/cancel_event * 📝 Update all links * 🐛 Sort redirects * chore: Merge suggestion #1 Co-authored-by: Estelle Weyl <[email protected]> * chore: Merge suggestion #2 Co-authored-by: Estelle Weyl <[email protected]> * chore: Merge suggestion #3 Co-authored-by: Estelle Weyl <[email protected]> * chore: Merge suggestion #4 Co-authored-by: Estelle Weyl <[email protected]> * chore: Merge suggestion (5) Co-authored-by: Estelle Weyl <[email protected]> * chore: Merge suggestion (6) Co-authored-by: Estelle Weyl <[email protected]> * Update files/en-us/web/html/element/input/file/index.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Estelle Weyl <[email protected]> Co-authored-by: Estelle Weyl <[email protected]>

* chore: replace create-react-app with vite * chore: .js --> .jsx * chore: add dev script section * chore: update App component walkthrough * fix: use correct h1 link * feat: rewrite more * chore: apply suggestions from review Co-authored-by: Chris Mills <[email protected]> * chore: fix npm script syntax * chore: rewrite node install instructions * chore: delete extraneous section * chore: delete image from replacement code * chore: add syntax explainer * chore: clean up final section * chore: rewrite jsx section * chore: nitpick notes * chore: delete React 17 note * chore(nit): hard drive -> machine * chore: apply suggestions from code review Co-authored-by: Chris Mills <[email protected]> * remove superfluous quote * chore: replace create-react-app image with vite * chore: index.jsx --> main.jsx * chore: clean up prop-comment section * chore: delete note on multi-word attributes * chore: use code syntax in heading * chore: change npm script note * chore: update note again * chore: fix image alt * chore: apply suggestions from code review Co-authored-by: Chris Mills <[email protected]> * chore: replace rollup mention with generic bundler reference * chore: document assets directory * chore: document lockfile * chore: disambiguate app function and component * chore: add some * Small App() related tweaks --------- Co-authored-by: Chris Mills <[email protected]>

fix: grammar in mixed_content md (#1)

teoli2003 and others added 30 commits March 29, 2022 11:02

Add spaces inside inline braces (mdn#14439)

142b436

Fixes mdn#14438

Update tablist accessibility guidelines (mdn#14150)

3337816

docs(SubtleCrypto): fix example code (mdn#14446)

4c6dbfb

`generateKey` returns a Promise. The variable names (`key` and `keyPair`) seem to indicate that these are actual values, but unawaited they are promises. Adding an await makes that more clear.

Array.groupByXxxx - clarify thisArg (mdn#14421)

23903ac

Fix developers.google.com link (mdn#14449)

d2e7fb4

* Fix developers.google.com link * Update files/en-us/web/api/console/dir/index.md Co-authored-by: wbamberg <[email protected]> Co-authored-by: wbamberg <[email protected]>

Update index.md (mdn#14453)

8f3294a

PWA Add to home icon is now install menu (mdn#14419)

9cd2be8

* PWA Add to home icon is now install menu * typo Co-authored-by: wbamberg <[email protected]>

Fix GitHub case when used as a word - nitpicking (part 2) (mdn#14457)

7637345

WebAPI: Clean syntax from property pages, part 11 (mdn#14455)

7ddeba7

* WebAPI: Clean syntax from property pages, part 11.1 * WebAPI: Clean syntax from property pages, part 11.2

Fix grammar issue (mdn#14364)

2e90fdf

* Fix grammar issue * Update files/en-us/web/api/geolocation/clearwatch/index.md Co-authored-by: Jean-Yves Perrier <[email protected]> Co-authored-by: Jean-Yves Perrier <[email protected]>

Fix developers.google.com link (mdn#14450)

db2b3ce

Fix link to the “labelable” content category in HTML <label> (mdn#1…

f64b7c4

…4426)

Property pages structure fix (part 12) (mdn#14456)

e54fd25

Replace this inside an arrow function (mdn#14463)

78dfe9d

Arrow functions does not have their own 'this' context. Replacing 'this' with 'volumeSlider' to access value property or we can replace the arrow function with 'function ()' and use 'this' to access value.

Update with info on AblePlayer (mdn#13065)

80ff77c

FF100 Remove HTTP Large-Allocation Header (mdn#14423)

f73a6b1

* FF98 Remove HTTP Large-Allocation * Apply suggestions from code review Co-authored-by: Ruth John <[email protected]> Co-authored-by: Ruth John <[email protected]>

Update timeZone constant name (mdn#14468)

07d7a6d

Correct `timeZoneName` and mention what default value of `timeZone` is.

Fix private methods link (mdn#14471)

10190da

* Fix private methods link Add `/` to the private methods link to make it work. * Update files/en-us/web/javascript/closures/index.md Co-authored-by: wbamberg <[email protected]> Co-authored-by: wbamberg <[email protected]>

Fix developers.google.com link (mdn#14466)

11012c1

Fix typo (mdn#14465)

244eec0

Remove ServiceWorkerMessageEvent; redirect to MessageEvent (mdn#14472)

719cc61

Fix developers.google.com link (mdn#14473)

b2db594

Replace use of XSS-prone innerHTML with safe textContent (mdn#14476)

a3f6647

Remove old screenshot; fix a flaw (mdn#14477)

9f9bcb9

Update index.md adapting the module title (mdn#12029)

eaf00bd

* Update index.md adapting the module title Because the other modules in this course also always have "CSS" in front of them. * Change just the title not the slug * Change text of links accordingly * Change text of link accordingly

Fix developers.google.com link (mdn#14483)

ca40876

* Fix developers.google.com link * fix

WritableStream: example, fixed block character in the output (mdn#14371)

88ecdef

Major Update: treegrid role (mdn#13474)

66d161f

Co-authored-by: Eric Bailey <[email protected]>

OnkarRuikar and others added 23 commits April 3, 2022 08:14

HTMLElement: fixed a typo (mdn#14609)

83c3630

Animation: fixed a typo (mdn#14611)

1e561b8

Notification: fixed a typo (mdn#14612)

638403c

Image() : marked parameters optional (mdn#14613)

4f45d21

Fixed a missing full stop (mdn#14616)

1f36c28

Corrected grammar, punctuation and spelling errors and fixed broken l…

5c3180f

…inks (mdn#14617) * Corrected grammar, punctuation and spelling errors * Fixed broken links

Corrected grammar (mdn#14618)

c1a0af2

Rewrite syntax for createelementns method (mdn#14619)

11f9240

* Replace var with let * Update files/en-us/web/api/document/createelementns/index.md Co-authored-by: Jean-Yves Perrier <[email protected]> Co-authored-by: Jean-Yves Perrier <[email protected]>

Minor grammar, punctuation and vocabulary corrections (mdn#14621)

a227192

* Corrected grammar * Corrected grammar, punctuation and vocabulary * Corrected punctuation and grammar

Fix developers.google.com links (mdn#14623)

2873c93

* Update index.md * Update index.md * Update index.md * Update index.md * Update index.md * Update index.md * Update index.md * Update index.md * Update index.md * Update index.md * Update index.md

Fix developers.google.com links (mdn#14624)

179ecd0

* Update index.md * Update index.md * Update index.md

Replace {{event)}} with domxref (mdn#14582)

ddb8a71

Fix inconsistent titles (mdn#14622)

83610a7

Fix grammatical typo (mdn#14631)

9108137

Remove typo in 'Writing WebSocket servers' (mdn#14632)

40eaa98

prop 21 (mdn#14634)

cad2828

WebAPI: Clean syntax from property pages, part 20 (mdn#14633)

4afce6d

Fix broken links to Emscripten.org (mdn#14635)

c854681

Wasm: remove preference versions (mdn#14638)

43b92a4

Replace {{event)}} with domxref (batch #2) (mdn#14578)

ce44990

* Replace {{event)}} with domxref * icegatherstatechange * Fix payerdetailchange event.

WASM: Better spec link for "Trap" (mdn#14639)

97cd889

Http ifmatch (mdn#14630)

0333e53

Remove the remaining occurrence of {{draft}}

0d49de9

teoli2003 closed this Apr 4, 2022

dipikabh pushed a commit that referenced this pull request Nov 4, 2024

Fix: Typo and grammar (mdn#36604)

e67d186

fix: grammar in mixed_content md (#1)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Remove draft#1

Remove draft#1
teoli2003 wants to merge 135 commits intodipikabh:mainfrom
teoli2003:remove-draft

teoli2003 commented Apr 4, 2022

Uh oh!

teoli2003 commented Apr 4, 2022

Uh oh!

teoli2003 commented Apr 4, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Comments

Conversation

teoli2003 commented Apr 4, 2022

Uh oh!

teoli2003 commented Apr 4, 2022

Uh oh!

teoli2003 commented Apr 4, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants