2626#include " arrow/type_traits.h"
2727#include " arrow/util/bitmap_reader.h"
2828#include " arrow/util/checked_cast.h"
29+ #include " arrow/util/float16.h"
2930
3031namespace arrow {
3132namespace compute {
@@ -106,6 +107,16 @@ TEST(TestValidityKernels, IsFinite) {
106107 CheckScalar (" is_finite" ,
107108 {ArrayFromJSON (duration (TimeUnit::SECOND ), " [0, 1, 42, null]" )},
108109 ArrayFromJSON (boolean (), " [true, true, true, null]" ));
110+ CheckScalar (" is_finite" , {ArrayFromJSON (float32 (), " [1.0, NaN, Inf, null]" )},
111+ ArrayFromJSON (boolean (), " [true, false, false, null]" ));
112+ CheckScalar (" is_finite" , {ArrayFromJSON (float64 (), " [1.0, NaN, Inf, null]" )},
113+ ArrayFromJSON (boolean (), " [true, false, false, null]" ));
114+ CheckScalar (" is_finite" , {ArrayFromJSON (float16 (), " [1.0, NaN, Inf, null]" )},
115+ ArrayFromJSON (boolean (), " [true, false, false, null]" ));
116+
117+ // Verifies that actual uint16s don't use IsFiniteOperator
118+ CheckScalar (" is_finite" , {ArrayFromJSON (uint16 (), " [1, null]" )},
119+ ArrayFromJSON (boolean (), " [true, null]" ));
109120}
110121
111122TEST (TestValidityKernels, IsInf) {
@@ -121,6 +132,16 @@ TEST(TestValidityKernels, IsInf) {
121132 ArrayFromJSON (boolean (), " [null, null, null, null]" ));
122133 CheckScalar (" is_inf" , {ArrayFromJSON (duration (TimeUnit::SECOND ), " [0, 1, 42, null]" )},
123134 ArrayFromJSON (boolean (), " [false, false, false, null]" ));
135+ CheckScalar (" is_inf" , {ArrayFromJSON (float32 (), " [1.0, NaN, Inf, null]" )},
136+ ArrayFromJSON (boolean (), " [false, false, true, null]" ));
137+ CheckScalar (" is_inf" , {ArrayFromJSON (float64 (), " [1.0, NaN, Inf, null]" )},
138+ ArrayFromJSON (boolean (), " [false, false, true, null]" ));
139+ CheckScalar (" is_inf" , {ArrayFromJSON (float16 (), " [1.0, NaN, Inf, null]" )},
140+ ArrayFromJSON (boolean (), " [false, false, true, null]" ));
141+
142+ // Verifies that actual uint16s don't use IsNanOperator
143+ CheckScalar (" is_inf" , {ArrayFromJSON (uint16 (), " [1, null]" )},
144+ ArrayFromJSON (boolean (), " [false, null]" ));
124145}
125146
126147TEST (TestValidityKernels, IsNan) {
@@ -136,6 +157,16 @@ TEST(TestValidityKernels, IsNan) {
136157 ArrayFromJSON (boolean (), " [null, null, null, null]" ));
137158 CheckScalar (" is_nan" , {ArrayFromJSON (duration (TimeUnit::SECOND ), " [0, 1, 42, null]" )},
138159 ArrayFromJSON (boolean (), " [false, false, false, null]" ));
160+ CheckScalar (" is_nan" , {ArrayFromJSON (float32 (), " [0.0, 1.0, NaN, 2.5, null]" )},
161+ ArrayFromJSON (boolean (), " [false, false, true, false, null]" ));
162+ CheckScalar (" is_nan" , {ArrayFromJSON (float64 (), " [0.0, 1.0, NaN, 2.5, null]" )},
163+ ArrayFromJSON (boolean (), " [false, false, true, false, null]" ));
164+ CheckScalar (" is_nan" , {ArrayFromJSON (float16 (), " [1.2, NaN, 2.5, NaN, 6, null]" )},
165+ ArrayFromJSON (boolean (), " [false, true, false, true, false, null]" ));
166+
167+ // Verifies that actual uint16s don't use IsNanOperator
168+ CheckScalar (" is_nan" , {ArrayFromJSON (uint16 (), " [1, null]" )},
169+ ArrayFromJSON (boolean (), " [false, null]" ));
139170}
140171
141172TEST (TestValidityKernels, IsValidIsNullNullType) {
0 commit comments