MNFS-164: Added NFS resize and snapshot APIs #921
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
btaaron75
approved these changes
Oct 15, 2025
nfs.go
Outdated
| // Region is the datacenter region where the NFS snapshot is located | ||
| Region string `json:"region"` | ||
| // Status represents the current status of the NFS snapshot | ||
| Status string `json:"status"` |
Contributor
There was a problem hiding this comment.
Can this status be an enum
nfs.go
Outdated
| } | ||
|
|
||
| // List returns a list of NFS snapshots. | ||
| func (s *NfsServiceOp) ListSnapshots(ctx context.Context, opts *ListOptions, id, region string) ([]*NfsSnapshot, *Response, error) { |
Contributor
There was a problem hiding this comment.
Suggested change
| func (s *NfsServiceOp) ListSnapshots(ctx context.Context, opts *ListOptions, id, region string) ([]*NfsSnapshot, *Response, error) { | |
| func (s *NfsServiceOp) ListSnapshots(ctx context.Context, opts *ListOptions, shareID, region string) ([]*NfsSnapshot, *Response, error) { |
nfs_actions.go
Outdated
| "net/http" | ||
| ) | ||
|
|
||
| // NfsActionsService is an interface for interfacing with the NFS actions |
Contributor
There was a problem hiding this comment.
Suggested change
| // NfsActionsService is an interface for interfacing with the NFS actions | |
| // NfsActionsService is an interface for interacting with the NFS actions |
nfs_actions.go
Outdated
| // endpoints of the DigitalOcean API | ||
| // See: https://docs.digitalocean.com/reference/api/api-reference/#tag/NFS-Actions | ||
| type NfsActionsService interface { | ||
| Resize(context.Context, string, uint64, string) (*Action, *Response, error) |
Contributor
There was a problem hiding this comment.
Suggested change
| Resize(context.Context, string, uint64, string) (*Action, *Response, error) | |
| Resize(context.Context, shareID string, size uint64, region string) (*Action, *Response, error) |
nfs.go
Outdated
Comment on lines
14
to
27
| // List retrieves a list of NFS shares filtered by region | ||
| List(context.Context, *ListOptions, string) ([]*Nfs, *Response, error) | ||
| // Create creates a new NFS share with the provided configuration | ||
| Create(context.Context, *NfsCreateRequest) (*Nfs, *Response, error) | ||
| // Delete removes an NFS share by its ID and region | ||
| Delete(context.Context, string, string) (*Response, error) | ||
| // Get retrieves a specific NFS share by its ID and region | ||
| Get(context.Context, string, string) (*Nfs, *Response, error) | ||
| // List retrieves a list of NFS snapshots filtered by an optional share ID and region | ||
| ListSnapshots(context.Context, *ListOptions, string, string) ([]*NfsSnapshot, *Response, error) | ||
| // Get retrieves a specific NFS snapshot by its ID and region | ||
| GetSnapshot(context.Context, string, string) (*NfsSnapshot, *Response, error) | ||
| // Delete removes an NFS snapshot by its ID and region | ||
| DeleteSnapshot(context.Context, string, string) (*Response, error) |
Contributor
There was a problem hiding this comment.
Add vars meaningful names
SSharma-10
approved these changes
Oct 17, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of MNFS-164. Follow up of #912. Adding NFS resize and snapshot APIs and corresponding tests to godo.