Feature/ssh#20
Conversation
nedtwigg
left a comment
There was a problem hiding this comment.
Great, thanks a lot! I think the default behavior here is too risky, we can either gate this risky behavior behind a flag, or we can force users to make sure their SSH known_hosts stuff is accurate.
spotless-changelog-lib/src/main/java/com/diffplug/spotless/changelog/GitActions.java
Outdated
Show resolved
Hide resolved
nedtwigg
left a comment
There was a problem hiding this comment.
Sorry I didn't think to suggest this earlier, but it jumped out at me as I looked at the new commits. There might be other SSH properties that users want to override in the future, and that will be easier if we have a consistent mapping.
I think the whole thing gets a bit simpler if we do this rename:
boolean sshDisableStrictHostKeyChecking = false;
String sshStrictHostKeyChecking = "yes";
That way we can automatically support any other String modes that SSH might have someday, and it's a consistent way to override whichever ssh config properties we add support for in the future.
spotless-changelog-lib/src/main/java/com/diffplug/spotless/changelog/GitActions.java
Outdated
Show resolved
Hide resolved
spotless-changelog-lib/src/main/java/com/diffplug/spotless/changelog/GitActions.java
Outdated
Show resolved
Hide resolved
spotless-changelog-lib/src/main/java/com/diffplug/spotless/changelog/GitCfg.java
Outdated
Show resolved
Hide resolved
...g-plugin-gradle/src/main/java/com/diffplug/spotless/changelog/gradle/ChangelogExtension.java
Show resolved
Hide resolved
...elog-plugin-gradle/src/main/java/com/diffplug/spotless/changelog/gradle/ChangelogPlugin.java
Outdated
Show resolved
Hide resolved
|
Published in |
this can resolve #19, but actually the StrictHostKeyChecking property is set to 'no'