Conversation
jbduncan
reviewed
Aug 20, 2021
Member
jbduncan
left a comment
jbduncan
left a comment
There was a problem hiding this comment.
Just a couple of nit-related comments from me, but otherwise this change seems very pragmatic to me. Well done! 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this should fix #775.
The problem was that the doclet we used to put markdown into our javadoc required JDK8, so we just disabled the javadoc task on non-JDK8 machines. Rather than figure out how to get the doclet working on JDK11 or change our publishing JDK, I just removed the doclet and replaced the markdown-style code ticks with javadoc-style
{@codeblocks. I wish javadoc supported markdown, but it's not worth fighting the ecosystem over it.