Fix SQL whitespace handing in comments#897
Merged
nedtwigg merged 1 commit intodiffplug:mainfrom Jul 20, 2021
Merged
Conversation
533fcd1 to
c526bb8
Compare
Member
|
Thanks for the PR! A few nits before we can merge:
|
This fixes several issues to how whitespace was formatted related to
comments in SQL formatter:
- A line after the comment would get an additional leading space, this
was especially visible for multi-line comments. For example:
```
-- comment
CREATE TABLE ...
```
Would be formatted as:
```
-- comment
CREATE TABLE ...
```
- An inline comment would be indented and placed on a separate line.
For example:
```
CREATE TABLE products (
category_id INTEGER, -- lookup in categories table
color VARCHAR(50),
)
```
Would be formatted as:
```
CREATE TABLE products (
category_id INTEGER,
-- lookup in categories table
color VARCHAR(50),
)
```
This fixes those issues in by patching these specific cases.
c526bb8 to
39a1102
Compare
Contributor
Author
|
@nedtwigg fixed |
Member
|
Thanks for the PR. Released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes several issues to how whitespace was formatted related to
comments in SQL formatter:
was especially visible for multi-line comments. For example:
For example: