Bump ktfmt to 0.21 and add support to Google and Kotlinlang formats#812
Merged
nedtwigg merged 1 commit intodiffplug:mainfrom Mar 5, 2021
JavierSegoviaCordoba:ktfmt-multiple-style
Merged
Bump ktfmt to 0.21 and add support to Google and Kotlinlang formats#812nedtwigg merged 1 commit intodiffplug:mainfrom JavierSegoviaCordoba:ktfmt-multiple-style
nedtwigg merged 1 commit intodiffplug:mainfrom
JavierSegoviaCordoba:ktfmt-multiple-style
Conversation
Closed
nedtwigg
requested changes
Mar 5, 2021
Member
nedtwigg
left a comment
nedtwigg
left a comment
There was a problem hiding this comment.
- add link to this PR in
plugin-gradle/CHANGES.md, and put it under### Added - copy this entry also to
plugin-maven/CHANGES.mdandCHANGES.md
I noted an optional refactor below. Nice to have but not necessary for a merge-and-release.
Contributor
Author
|
@nedtwigg has spotless a way to compare two versions so I can delete the |
nedtwigg
requested changes
Mar 5, 2021
Member
nedtwigg
left a comment
nedtwigg
left a comment
There was a problem hiding this comment.
The version check is nice, but needs to be thread-safe.
nedtwigg
requested changes
Mar 5, 2021
Member
nedtwigg
left a comment
nedtwigg
left a comment
There was a problem hiding this comment.
Still missing an entry in the root CHANGES.md. Once that gets done I think this is ready to merge and release.
Member
|
Released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manually tested, @cgrushko can you take a look at this PR?
Should
getCustomFormattingOptionshave a better way to manage ktfmt versioning availability? I was thinking about adding to theStyleenum asinceproperty to throw errors.EDIT:
I added the
sinceproperty so spotless will throw an exception if the user tries to use a ktfmt version that doesn't have a specific format.