Support diktat - Kotlin code style analyzer #789
Conversation
76de19b to
e5c1efb
Compare
nedtwigg
left a comment
There was a problem hiding this comment.
Thanks, great PR! Few minor changes required before merging.
|
737eff1 to
ef74b83
Compare
Thanks! Added changes to the CHANGES.md files and made the necessary edits. |
…es for detecting code smells, code style issues and bugs. https://github.com/cqfn/diKTat/blob/master/README.md
ef74b83 to
9b5b488
Compare
|
I guess it should be linked with #409 |
nedtwigg
left a comment
There was a problem hiding this comment.
Thanks very much, great PR! One minor question left. Don't worry about changing it, just answer the question and I can change it (I've got a few other tiny nits which are easier if I just do them).
Btw, I find it easier to review PRs if you push up new commits, rather than force-pushing over old-ones. We can always squash down if things get messy, but we can't unsquash :)
|
Thanks for a great PR @Cheshiriks! Published in |
|
|
Hey @nedtwigg, we have added description of spotless integration in diktat readme in saveourtool/diktat#762, you can check it out here 👍 |
|
Hi @nedtwigg I am trying to integrate |
Yes, because it's needed for up-to-date checks. If you want to download a config from a remote URL, I recommend https://github.com/diffplug/blowdryer |
@lyharrietbui I do not think that you need to download config file from the remote URL, you can put it to your project folder. Gradle will automatically calculate paths from the rootDir and you will override the default configuration with the custom one. |
Diktat is a strict coding standard for Kotlin and a custom set of rules for detecting code smells, code style issues and bugs.
https://github.com/cqfn/diKTat/blob/master/README.md