Deprecate -PspotlessFiles from gradle (still available in maven) #602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 5, 2020
Merged
Closed
nedtwigg
changed the title
Contributor
|
From what I understand it's not worth looking into fixing it? |
Member
Author
|
It is removed from gradle, but still used in maven. Probably spotless/lib/src/main/java/com/diffplug/spotless/FileSignature.java Lines 122 to 125 in 5d965e7 We have a pretty big test matrix, but I guess we're not testing the maven plugin on windows... It's not critical to fix, but if you're already in the weeds it would be nice to fix. |
Contributor
|
There's some issue with patterns from what I can get. Replacing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-PspotlessFileshas been deprecated and will be removed. It is slow and error-prone, especially for win/unix cross-platform, and we have better options available now:ratchetFrom 'origin/master'