Be proactive about encoding mismatch#575
Merged
Conversation
…s frankly astonishing!
Member
Author
|
If you've got time, I'd love your feedback @andrewfg |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As noted here, it is very destructive for Spotless to run an
applyoperation with an incorrect encoding set. If the encoding was incorrect, we should error loudly to prevent special characters from being changed.This PR is just a draft - We can make the error message a lot better, and we can probably go faster by never re-encoding to an entire
byte[], and instead just check against the existingbyte[]as we go. That also makes it easier to create a good error message, especially for multibyte encodings like UTF-8.