Skip to content

Using URI instead of URL for file lookup#405

Merged
fvgh merged 3 commits intomasterfrom
issue_401
Jun 6, 2019
Merged

Using URI instead of URL for file lookup#405
fvgh merged 3 commits intomasterfrom
issue_401

Conversation

@fvgh
Copy link
Copy Markdown
Member

@fvgh fvgh commented Jun 4, 2019

Using URI instead of URL for file lookup avoiding URL escape characters in path.

This change in eclipse-base fixes #401.
Since only a minor bug fix has been provided, only the patch version has been incremented.

All Spotless Eclipse based formatters are affected by #401. Hence their all dependency lock files require an update.

Note that the release date in the change log needs to be set.
Unit tests of the private static function are considered unnecessary.
Code change has been validated manually.

@fvgh fvgh requested a review from nedtwigg June 4, 2019 19:51
nedtwigg
nedtwigg approved these changes Jun 4, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@nedtwigg nedtwigg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I'll publish 3.1.1 and update the date.

@fvgh
Copy link
Copy Markdown
Member Author

fvgh commented Jun 4, 2019

As stated above, I would recommend to replace all spotless-eclipse-base:3.1.0 occurrences in the existing lock-files by spotless-eclipse-base:3.1.1.

A back-port of the patch for spotless-eclipse-base:3.0.0 is possible if requested.

Keep in mind that the minor version spotless-eclipse-base signals incompatibilities. Hence a replacement of spotless-eclipse-base:3.0.0 by spotless-eclipse-base:3.1.1 could cause run-time errors and is discouraged.

@nedtwigg Shall I do the lock-file update? As part of this branch/PR?

@nedtwigg
Copy link
Copy Markdown
Member

nedtwigg commented Jun 4, 2019 •
edited
Loading

3.1.1 published. I don't see a need for a back-port, but I'm happy to publish anything you would like published. I would do the lock-file update within this PR.

@fvgh
Copy link
Copy Markdown
Member Author

fvgh commented Jun 5, 2019 •
edited
Loading

Checked code changes since spotless-eclipse-base:3.0.0. Changes of spotless-eclipse-base:3.1.1 are compatible with version spotless-eclipse-base:3.0.0 and only depend on spotless-lib improvements.

Hence all spotless-eclipse-base version have been incremented to 3.1.1.

@nedtwigg
Copy link
Copy Markdown
Member

nedtwigg commented Jun 5, 2019

Looks great to me! Merge at will :)

@fvgh fvgh merged commit 33dc04d into master Jun 6, 2019
@fvgh fvgh deleted the issue_401 branch June 6, 2019 14:16
@nedtwigg
Copy link
Copy Markdown
Member

nedtwigg commented Jun 18, 2019

Released in x.23.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nedtwigg nedtwigg nedtwigg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

org.osgi.framework.BundleException

2 participants

@fvgh @nedtwigg