Is com.pinterest:ktlint the new official ktlint? What version is the first pinterest version? We care about backwards compatibility, so we should do a comparison, if version > blah then group ="com.pinterest" else group = "com.github.shyiko".

Here's how we resolved it for Ktlint-Gradle.

JLLeitschuh/ktlint-gradle#228

Since Ktlint implements SemVer for all versioning, we imported a library that supports SemVer comparisons to handle all this logic.

https://github.com/swiftzer/semver

@nedtwigg I don't know if you have an existing methodology for doing SemVer comparisons. Don't know what your thoughts are on adding a library to handle this sort of thing.

0.31.0 is the last of com.github.shyiko, 0.32.0 is the first for com.pinterest

https://mvnrepository.com/artifact/com.github.shyiko/ktlint
https://mvnrepository.com/artifact/com.pinterest/ktlint

what your thoughts are on adding a library to handle this sort of thing.

I'm against adding a dependency. Elsewhere in the code where we've had to change behavior based on a version, we've done feature-testing rather than version-testing, but that won't work here.

Every shyiko version has form 0.x.x, So if you did a regex like 0\.([0-9]+)\.([0-9]+) and then compared the digit to 31, that would work.

Also, we need to update plugin-maven/CHANGES.md and plugin-gradle/CHANGES.md. The same line that you used in CHANGES.md is fine.

Also, we need to update plugin-maven/CHANGES.md and plugin-gradle/CHANGES.md. The same line that you used in CHANGES.md is fine.

I did update those... working on putting a test in the core tests now.

LGTM, thanks! I'll let this breathe for 24 hrs then merge and release tomorrow.

Published in 3.23.0 / 1.23.0.