Update eclipse to version 4.11.0 (fix #381)#384
Merged
fvgh merged 1 commit intodiffplug:masterfrom Mar 26, 2019
iemejia:master
Merged
Update eclipse to version 4.11.0 (fix #381)#384fvgh merged 1 commit intodiffplug:masterfrom iemejia:master
fvgh merged 1 commit intodiffplug:masterfrom
iemejia:master
Conversation
fvgh
requested changes
Mar 26, 2019
Member
fvgh
left a comment
fvgh
left a comment
There was a problem hiding this comment.
Great. Thanks for the help! Could you provide the small changes?
| @@ -0,0 +1,19 @@ | |||
| # Spotless formatter based on JDT version 4.11.0 (see https://projects.eclipse.org/projects/eclipse.jdt) | |||
| # Compare tag in M2 pom with https://git.eclipse.org/c/jdt/eclipse.jdt.core.git/log/?h=R4_9_maintenance to determine core version. | |||
Member
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
Done and updated to the four latest revisions
| @Override | ||
| protected String[] getSupportedVersions() { | ||
| return new String[]{"4.6.1", "4.6.2", "4.6.3", "4.7.0", "4.7.1", "4.7.2", "4.7.3a", "4.8.0", "4.9.0", "4.10.0"}; | ||
| return new String[]{"4.6.1", "4.6.2", "4.6.3", "4.7.0", "4.7.1", "4.7.2", "4.7.3a", "4.8.0", "4.9.0", "4.10.0", |
Member
There was a problem hiding this comment.
The formatting is broken, that's why the build fails.
Run 'gradlew spotlessApply' to fix these violations.
Contributor
Author
There was a problem hiding this comment.
Done, it catched a .gradle formatting error too so I included it in the PR
Contributor
Author
|
Rebased and fixed issues. @fvgh PTAL |
Member
|
Published in x.21.0. Thanks for the code PR @iemejia. Let me know if you'd like any changes to this credit. |
Contributor
Author
|
That's perfect, thanks! |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.