Skip to content

Enable the buildcache - read only for PRs, and read/write for trusted…#380

Merged
nedtwigg merged 5 commits intomasterfrom
feature/buildcache
Mar 26, 2019
Merged

Enable the buildcache - read only for PRs, and read/write for trusted…#380
nedtwigg merged 5 commits intomasterfrom
feature/buildcache

Conversation

@nedtwigg
Copy link
Copy Markdown
Member

… builds (merged, internal PRs).

Please make sure that your PR allows edits from maintainers. Sometimes its faster for us to just fix something than it is to describe how to fix it.

Allow edits from maintainers

After creating the PR, please add a commit that adds a bullet-point under the -SNAPSHOT section of CHANGES.md and plugin-gradle/CHANGES.md which includes:

  • a summary of the change
  • either
    • a link to the issue you are resolving (for small changes)
    • a link to the PR you just created (for big changes likely to have discussion)

If your change only affects a build plugin, and not the lib, then you only need to update the CHANGES.md for that plugin.

If your change affects lib in an end-user-visible way (fixing a bug, updating a version) then you need to update CHANGES.md for both the lib and the build plugins. Users of a build plugin shouldn't have to refer to lib to see changes that affect them.

This makes it easier for the maintainers to quickly release your changes :)

@nedtwigg nedtwigg merged commit fdcbca9 into master Mar 26, 2019
@nedtwigg nedtwigg deleted the feature/buildcache branch March 26, 2019 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant