feat: supply Eclipse config from string#2337
Closed
tomasbjerre wants to merge 2 commits intodiffplug:mainfrom
tomasbjerre:feature/eclipse-config-without-file
Closed
feat: supply Eclipse config from string#2337tomasbjerre wants to merge 2 commits intodiffplug:mainfrom tomasbjerre:feature/eclipse-config-without-file
tomasbjerre wants to merge 2 commits intodiffplug:mainfrom
tomasbjerre:feature/eclipse-config-without-file
Conversation
Member
|
I would advise blowdryer for this. |
Contributor
Author
|
I will try to find some time to complete this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows a user to supply the configuration, needed by Eclipse formatter, as a string.
I have a precompiled script plugin that applies Spotless Gradle plugin with our Eclipse config. It would be easier if I did not have to supply a file in the configuration but just the content
A file means I have to have that file available for the plugin when it runs, actually it seems it is needed both during configuration and when the Spotless task runs. With content I can just read the content from some classpath resource in my precompiled script.
Would also be nice to be able to supply the configuration in XML format, but that can probably be a future PR.