Skip to content

Add option to configure management of trailing commas in ktfmt#2177

Merged
Goooler merged 3 commits intodiffplug:mainfrom
hick209:ktfmt-trailing-commas
Jun 18, 2024
Merged

Add option to configure management of trailing commas in ktfmt#2177
Goooler merged 3 commits intodiffplug:mainfrom
hick209:ktfmt-trailing-commas

Conversation

@hick209
Copy link
Copy Markdown
Contributor

@hick209 hick209 commented Jun 18, 2024

ktfmt has this property so let's expose it in Spotless.

@hick209 hick209 force-pushed the ktfmt-trailing-commas branch 2 times, most recently from 63a71ad to 5fea517 Compare June 18, 2024 14:59
@hick209 hick209 marked this pull request as ready for review June 18, 2024 15:40
Comment thread CHANGES.md
### Fixed
* Fix compatibility issue introduced by `ktfmt` `0.51`. ([#2172](https://github.com/diffplug/spotless/issues/2172))
### Added
* Added option `manageTrailingCommas` to `ktfmt`. ([#2177](https://github.com/diffplug/spotless/pull/2177))
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Added option `manageTrailingCommas` to `ktfmt`. ([#2177](https://github.com/diffplug/spotless/pull/2177))
* Added option `manageTrailingCommas` to `ktfmt`. ([#2177](https://github.com/diffplug/spotless/pull/2177))

Extra spaces was inserted, I'll fix them in a followup.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Goooler Goooler merged commit 3bce98e into diffplug:main Jun 18, 2024
@hick209 hick209 deleted the ktfmt-trailing-commas branch June 19, 2024 12:10
@nedtwigg
Copy link
Copy Markdown
Member

Released in plugin-gradle 7.0.0.BETA2 and plugin-maven 2.44.0.BETA2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants