Support for google-java-format's style option (AOSP style)#193
Merged
nedtwigg merged 2 commits intodiffplug:masterfrom Feb 5, 2018
Merged
Support for google-java-format's style option (AOSP style)#193nedtwigg merged 2 commits intodiffplug:masterfrom
nedtwigg merged 2 commits intodiffplug:masterfrom
Conversation
Added configuration option to switch the style of the googleJavaFormat step.
Member
|
Fantastic, thanks very much @ohorn! Do you mind adding a bullet to https://github.com/diffplug/spotless/blob/master/plugin-gradle/CHANGES.md and https://github.com/diffplug/spotless/blob/master/CHANGES.md I'll release this by Monday, if that's alright for your schedule. |
Member
|
I don't really have anything else to add here; this PR looks pretty durn good to me! Thank you very much from me as well @ohorn. :) |
Contributor
Author
|
Thank you. I've added some remarks to the |
Member
|
Published in libs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The google-java-format CLI exposes an option
--aospto switch from the default Google Java Style to AOSP-compliant style (4-space indentation). Such a configuration option is missing from Spotless.This PR adds a corresponding configuration option to Spotloss:
Internally, google-java-format implements the style option as an enum class. Therefore, I've added a second, more general configuration option to switch to any possible enum value. However, as of version 1.5, the only values are
GOOGLE(default) andAOSP.