Conversation
| @@ -0,0 +1,86 @@ | |||
| /* | |||
| * Copyright 2016 DiffPlug | |||
There was a problem hiding this comment.
...but we should probably change this to "2017". :)
There was a problem hiding this comment.
2018 is coming soon enough, I was gonna change our copyright notice then :) Also want to change the notice to point to https://github.com/diffplug/spotless/graphs/contributors
There was a problem hiding this comment.
Sounds very sensible to me. :)
| return input -> { | ||
| return (String) formatMethod.invoke(formatter, input); | ||
| }; | ||
| } |
There was a problem hiding this comment.
I don't know if this will work with Java 9.
There was a problem hiding this comment.
@JLLeitschuh Are you referring to the use of reflection here?
There was a problem hiding this comment.
Yes, the use of the classloader in this way.
There was a problem hiding this comment.
I'm probably missing something, but I'm not yet convinced it would be a problem on Java 9, as I have a real-world project using Java 9 and Spotless with google-java-format, and I've had no problems with Spotless or google-java-format specifically yet. (But it's worth noting that the project's using the classpath rather than the module-path, so I dunno how the JPMS would factor into things.)
|
#166 has this topic well-covered. |
3 participants
Skeleton implementation of #156.
HibernateStep is bad - not useful enough to ship. We should delete it, but shows a good starting point.