Skip to content

Homogeneize gradle and maven behavior around Formatter issues on a sp…#1615

Merged
nedtwigg merged 4 commits intodiffplug:mainfrom
blacelle:ImproveLogs_GradleInCaseOfException_MavenSynthesisOnCheck
Mar 10, 2023
Merged

Homogeneize gradle and maven behavior around Formatter issues on a sp…#1615
nedtwigg merged 4 commits intodiffplug:mainfrom
blacelle:ImproveLogs_GradleInCaseOfException_MavenSynthesisOnCheck

Conversation

@blacelle
Copy link
Copy Markdown
Contributor

@blacelle blacelle commented Mar 9, 2023

This would fix #868 by reporting explicitly a faulty file in gradle-plugin. SIUch error reporting is already present in maven plugin.

@blacelle blacelle marked this pull request as ready for review March 9, 2023 06:50
Copy link
Copy Markdown
Member

@nedtwigg nedtwigg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks! Minor changes requested below.

Comment thread plugin-gradle/src/main/java/com/diffplug/gradle/spotless/SpotlessTaskImpl.java Outdated
@nedtwigg nedtwigg merged commit ec85679 into diffplug:main Mar 10, 2023
@taofik69
Copy link
Copy Markdown

taofik69 commented Mar 10, 2023 via email

@blacelle blacelle deleted the ImproveLogs_GradleInCaseOfException_MavenSynthesisOnCheck branch March 10, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Encoding error! Spotless uses UTF-8 by default. " does not give filename of the affected file

3 participants