Update IndentStep to allow leading space on multi-line comments#1072
Merged
nedtwigg merged 5 commits intodiffplug:mainfrom Jan 7, 2022
Merged
Update IndentStep to allow leading space on multi-line comments#1072nedtwigg merged 5 commits intodiffplug:mainfrom
IndentStep to allow leading space on multi-line comments#1072nedtwigg merged 5 commits intodiffplug:mainfrom
Conversation
nedtwigg
requested changes
Jan 6, 2022
Member
nedtwigg
left a comment
nedtwigg
left a comment
There was a problem hiding this comment.
Great start, almost there :)
At present, `indentWithTabs` doesn't handle leading space on multi-line comments and reports errors on properly formatted code. This commit updates `IndentStep` to add support for detecting multi-line comments and allowing a single leading space for such lines. Closes diffplug#1070
nedtwigg
approved these changes
Jan 6, 2022
auto-merge was automatically disabled
January 6, 2022 19:30
Head branch was pushed to by a user without write access
Author
|
I pushed an additional commit that fixes the code style issue that caused the CI build to fail. @nedtwigg note that I did run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At present,
indentWithTabsdoesn't handle leading space on multi-line comments and reports errors on properly formatted code.This commit updates
IndentStepto add support for detecting multi-line comments and allowing a single leading space for such lines.Closes #1070