I've converted GJF to a compile-only integration. To reduce complexity, I would suggest that we'll require GJF of at least version 1.8 (which was released back in May 2020). Before that, we would have two API changes that would require to have specific compile-only variants. Since that version is years old, I don't think any spotless user would have an issue with that requirement.

After having converted GJF to a compile-only dependency, I've tried to introduce a configuration for the max-line-length. GJF however has taken every measure, for this property to not be changeable, as can be seen here:

https://github.com/google/google-java-format/blob/1a0065696b4f408313dbd24f9d6606d758e98868/core/src/main/java/com/google/googlejavaformat/java/Formatter.java#L89

They've decided to make this a public static final int that gets assigned on declaration. So even with (ugly) reflection, the value cannot be changed, since the compiler does inline this value wherever it is used within the gjf lib.

It was possible to change this value up to GJF Release 1.7 by doing some ugly wrapping of the JavaFormatterOptions class at this location:

https://github.com/google/google-java-format/blob/69e2efccf9938cfb08b1d5315ad61ca4484bbd0a/core/src/main/java/com/google/googlejavaformat/java/JavaFormatterOptions.java#L60-L64

This is, ultimately, what the aformentioned maven-plugin does:
https://github.com/talios/googleformatter-maven-plugin/blob/2034133fe14f0ee928c6942cd037f1fbd52f0abd/src/main/java/com/theoryinpractise/googleformatter/GoogleFormatterMojo.java#L142-L146

This approach, however, is no longer feasible, as it is only working for GJF Versions ≤ 1.7.

TL;DR: it is not possible to make GFJ's max-line-length property configurable. Which means this feature request cannot be satisfied.

@nedtwigg Given the above, should I create a PR to merge the transition of GJF to a compile-only dependency, or would you rather keep it "the old way" using reflection?

Set max line length for google formatter #1563

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions