Repository navigation
chore(desktop): update the bundled OpenCode v1 engine to 1.18.33 - #6414
Merged
Merged
Conversation
OpenCode 1.18.33 (anomalyco/opencode#51414) only launches http/https URLs from its browser opener, and the MCP OAuth provider rejects any other authorization URL before forwarding it. Before that, a remote MCP server's `authorization_endpoint` reached `open`, which hands the target to a shell on Windows and WSL. The pinned OpenCode v2 engine (2.0.26) already includes the matching v2 change (anomalyco/opencode#51412), so only the v1 pin moves. Signed-off-by: Jalil <[email protected]>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
reachjalil
temporarily deployed
to
pr-internal-specs
October 23, 2026 18:25 — with
GitHub Actions
Inactive
Contributor
OpenWork evidence
Run details · Open the preview to inspect evidence and sandbox options. |
Contributor
There was a problem hiding this comment.
Warden clearance. Complete security and confidentiality review of 434e7dc05c28ea20dc327a57fa5d64fc5e8d68e2 found no high or medium security findings and no confidentiality findings. Any new push dismisses this approval. Analysis run
Contributor
Warden: approvedNo high or medium security findings and no confidentiality findings. Reviewed |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this about?
Update the OpenCode v1 engine bundled with the desktop app and server from 1.18.30 to 1.18.33.
What problem does it solve?
A malicious remote MCP server could put a crafted OAuth
authorization_endpointin its metadata. OpenCode passed it toopen, which hands the target to a shell on Windows and WSL, so the server could run commands on a user's computer when they connected to it.What was the situation before?
Every desktop build and
openwork-serverruntime still on the v1 engine used 1.18.30. That version opened any authorization URL it was given, including non-web schemes.How is this implemented?
constants.json:opencodeVersionv1.18.30→v1.18.33.prepare-sidecar.mjs, the server's version check, the plugin-dependency archive, the CI setup action and the Daytona/microsandbox image scripts all read this pin.http:/https:URLs and rejects other authorization URLs in the MCP OAuth provider.What else changed?
Release note
The desktop app now bundles OpenCode 1.18.33, which only opens web links when a remote MCP server asks you to sign in.
Evidence
No E2E; engine pin only. Release v1.18.33 has every asset
prepare-sidecar.mjsdownloads. The darwin-arm64 binary reports1.18.33.node apps/server/scripts/build-opencode-plugin-deps.mjsbuildsopencode-plugin-deps-1.18.33.tgzand passes its portable-code check.