Skip to content

C library: model __builtin_powi{,f,l} #8192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tautschnig merged 1 commit into from
Feb 21, 2024
Merged

C library: model __builtin_powi{,f,l} #8192

tautschnig merged 1 commit into from
Feb 21, 2024

Conversation

@tautschnig
Copy link
Collaborator

@tautschnig tautschnig commented Feb 6, 2024

These GCC built-ins are modelled by invoking their non-integer counterparts pow{,f,l}.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig tautschnig requested a review from kroening as a code owner February 6, 2024 13:31
@codecov
Copy link

codecov bot commented Feb 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9c7bccc) 79.66% compared to head (e26fc74) 79.66%.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #8192   +/-   ##
========================================
  Coverage    79.66%   79.66%           
========================================
  Files         1682     1682           
  Lines       195377   195377           
========================================
  Hits        155641   155641           
  Misses       39736    39736

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tautschnig tautschnig added the Kani Bugs or features of importance to Kani Rust Verifier label Feb 6, 2024
tautschnig added a commit to tautschnig/kani that referenced this pull request Feb 7, 2024
@tautschnig
Enable powif* intrinsics
ea28adf 
These are supported by CBMC with
diffblue/cbmc#8192 merged.

Resolves: model-checking#2763
@tautschnig tautschnig mentioned this pull request Feb 7, 2024
Merged
@tautschnig tautschnig force-pushed the features/builtin_pow branch 2 times, most recently from 539965a to a0744d7 Compare February 12, 2024 17:07
@tautschnig
C library: model __builtin_powi{,f,l}
e26fc74 
These GCC built-ins are modelled by implementing pow{,f,l} specialised
to integral exponents (where multiple failure cases cannot occur).
@tautschnig tautschnig merged commit 4cb0a63 into diffblue:develop Feb 21, 2024
@tautschnig tautschnig deleted the features/builtin_pow branch February 21, 2024 08:40
tautschnig added a commit to model-checking/kani that referenced this pull request Aug 2, 2024
@tautschnig
Enable powif* intrinsics (#2999)
6ae3f00 
These are supported by CBMC with
diffblue/cbmc#8192 merged.

Resolves: #2763
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kroening kroening kroening approved these changes

@peterschrammel peterschrammel Awaiting requested review from peterschrammel peterschrammel is a code owner

@remi-delmas-3000 remi-delmas-3000 Awaiting requested review from remi-delmas-3000 remi-delmas-3000 is a code owner

Assignees

@kroening kroening

@remi-delmas-3000 remi-delmas-3000

@peterschrammel peterschrammel

Labels

C Front End Kani Bugs or features of importance to Kani Rust Verifier

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tautschnig @kroening @remi-delmas-3000 @peterschrammel