Auto merge of rust-lang#117248 - ChrisDenton:ci-symlink, r=m-ou-se

bors · bors · commit 9cf18e98f82d · 2023-12-01T19:34:40.000Z
Error if symlinks are not supported in CI

In CI we want to run as many tests as possible and be alerted if a test isn't run for any reason.
diff --git a/library/std/src/fs/tests.rs b/library/std/src/fs/tests.rs
@@ -74,7 +74,7 @@ macro_rules! error_contains {
 // tests most of the time, but at least we do if the user has the right
 // permissions.
 pub fn got_symlink_permission(tmpdir: &TempDir) -> bool {
-    if cfg!(unix) {
+    if cfg!(not(windows)) || env::var_os("CI").is_some() {
         return true;
     }
     let link = tmpdir.join("some_hopefully_unique_link_name");

Original file line number	Diff line number	Diff line change
`@@ -74,7 +74,7 @@ macro_rules! error_contains {`
`74`	`74`	`// tests most of the time, but at least we do if the user has the right`
`75`	`75`	`// permissions.`
`76`	`76`	`pub fn got_symlink_permission(tmpdir: &TempDir) -> bool {`
`77`		`- if cfg!(unix) {`
	`77`	`+ if cfg!(not(windows)) \|\| env::var_os("CI").is_some() {`
`78`	`78`	`return true;`
`79`	`79`	`}`
`80`	`80`	`let link = tmpdir.join("some_hopefully_unique_link_name");`