fix: GetDynamicStyle panic (#29)

dhth · web-flow · commit 7ea7a3def3e2 · 2024-08-13T02:45:45.000+05:30
diff --git a/.github/workflows/back-compat-pr.yml b/.github/workflows/back-compat-pr.yml
@@ -16,7 +16,10 @@ env:
 jobs:
   check-back-compat:
     name: build
-    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        os: [ubuntu-latest, macos-latest]
+    runs-on: ${{ matrix.os }}
     steps:
     - uses: actions/checkout@v4
     - name: Set up Go
diff --git a/.github/workflows/back-compat.yml b/.github/workflows/back-compat.yml
@@ -13,7 +13,10 @@ env:
 jobs:
   check-back-compat:
     name: build
-    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        os: [ubuntu-latest, macos-latest]
+    runs-on: ${{ matrix.os }}
     steps:
     - uses: actions/checkout@v4
       with:
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -18,7 +18,10 @@ env:
 jobs:
   build:
     name: build
-    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        os: [ubuntu-latest, macos-latest]
+    runs-on: ${{ matrix.os }}
     steps:
     - uses: actions/checkout@v4
     - name: Set up Go
@@ -29,10 +32,6 @@ jobs:
       run: go build -v ./...
     - name: go test
       run: go test -v ./...
-    - name: golangci-lint
-      uses: golangci/golangci-lint-action@v6
-      with:
-        version: v1.58
     - name: run omm
       run: |
         go build .
diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
@@ -0,0 +1,31 @@
+name: lint
+
+on:
+  push:
+    branches: [ "main" ]
+  pull_request:
+    paths:
+      - "go.*"
+      - "**/*.go"
+      - ".github/workflows/*.yml"
+
+permissions:
+  contents: read
+
+env:
+  GO_VERSION: '1.22.5'
+
+jobs:
+  lint:
+    name: lint
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v4
+    - name: Set up Go
+      uses: actions/setup-go@v5
+      with:
+        go-version: ${{ env.GO_VERSION }}
+    - name: golangci-lint
+      uses: golangci/golangci-lint-action@v6
+      with:
+        version: v1.58
diff --git a/internal/types/types.go b/internal/types/types.go
@@ -144,7 +144,7 @@ func GetDynamicStyle(str string) lipgloss.Style {
 	h.Write([]byte(str))
 	hash := h.Sum32()
 
-	color := colors[int(hash)%len(colors)]
+	color := colors[hash%uint32(len(colors))]
 	return lipgloss.NewStyle().
 		Foreground(lipgloss.Color(color))
 }
diff --git a/internal/types/types_test.go b/internal/types/types_test.go
@@ -0,0 +1,15 @@
+package types
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+)
+
+func TestGetDynamicStyle(t *testing.T) {
+	input := "abcdefghi"
+	gota := GetDynamicStyle(input)
+	gotb := GetDynamicStyle(input)
+	// assert same style returned for the same string
+	assert.Equal(t, gota.GetBackground(), gotb.GetBackground())
+}

Original file line number	Diff line number	Diff line change
`@@ -144,7 +144,7 @@ func GetDynamicStyle(str string) lipgloss.Style {`
`144`	`144`	`h.Write([]byte(str))`
`145`	`145`	`hash := h.Sum32()`
`146`	`146`
`147`		`- color := colors[int(hash)%len(colors)]`
	`147`	`+ color := colors[hash%uint32(len(colors))]`
`148`	`148`	`return lipgloss.NewStyle().`
`149`	`149`	`Foreground(lipgloss.Color(color))`
`150`	`150`	`}`