fix: potential panic when getting dynamic styles

dhth · dhth · commit e16a50091a46 · 2024-08-26T08:25:38.000+02:00
diff --git a/internal/ui/styles.go b/internal/ui/styles.go
@@ -140,7 +140,7 @@ var (
 		h.Write([]byte(str))
 		hash := h.Sum32()
 
-		color := taskColors[int(hash)%len(taskColors)]
+		color := taskColors[hash%uint32(len(taskColors))]
 		return lipgloss.NewStyle().
 			Foreground(lipgloss.Color(color))
 	}
diff --git a/internal/ui/styles_test.go b/internal/ui/styles_test.go
@@ -0,0 +1,15 @@
+package ui
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+)
+
+func TestGetDynamicStyle(t *testing.T) {
+	input := "abcdefghi"
+	gota := getDynamicStyle(input)
+	gotb := getDynamicStyle(input)
+	// assert same style returned for the same string
+	assert.Equal(t, gota.GetForeground(), gotb.GetForeground())
+}

Original file line number	Diff line number	Diff line change
`@@ -140,7 +140,7 @@ var (`
`140`	`140`	`h.Write([]byte(str))`
`141`	`141`	`hash := h.Sum32()`
`142`	`142`
`143`		`- color := taskColors[int(hash)%len(taskColors)]`
	`143`	`+ color := taskColors[hash%uint32(len(taskColors))]`
`144`	`144`	`return lipgloss.NewStyle().`
`145`	`145`	`Foreground(lipgloss.Color(color))`
`146`	`146`	`}`