Skip to content

Implicit declaration of memcpy#8

Merged
dhil merged 2 commits into
dhil:mainfrom
tmcgilchrist:warnings
Apr 27, 2024
Merged

Implicit declaration of memcpy#8
dhil merged 2 commits into
dhil:mainfrom
tmcgilchrist:warnings

Conversation

@tmcgilchrist

Copy link
Copy Markdown
Contributor

ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]

This was failing on macOS (14.4.1) with Apple clang version 15.0.0 (clang-1500.3.9.4).

ISO C99 and later do not support implicit function declarations
[-Wimplicit-function-declaration]
@tmcgilchrist

Copy link
Copy Markdown
Contributor Author

CI passes based on tmcgilchrist#1

@dhil dhil left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@dhil dhil merged commit 1e83cbc into dhil:main Apr 27, 2024
dhil added a commit to dhil/opam-repository that referenced this pull request May 14, 2024
CHANGES:

This release restores compatibility with macOS (14.4.1) when using
clang 15 or greater.

Changes:

* Patch dhil/ocaml-multicont#8: Explicit declaration of `memcpy` to fix compilation error
  when using clang on macOS (thanks to @tmcgilchrist).
* Fixed a regression where enabling feature flag `UNIQUE_FIBERS`
  caused compilation to fail.
* Spring cleaning: Removed unused header imports.
* Added an example illustrating how to use the power of multishot
  continuation to simulate the `return` operator (e.g. as found in
  C/C++/Rust/etc) using a single handler.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants