Repository navigation
Commit cd6955d
[flutter_tools] Handle Windows reserved characters in test target path (flutter#191900)
### Description
Catch `ArgumentError` and `FormatException` in
`TestCommand._parseTestArgument` when test target arguments contain
Windows reserved characters or unexpanded globs, emitting a clean
`ToolExit` instead of crashing.
Fixes flutter#191896
### Tests
- Added hermetic unit test in
`packages/flutter_tools/test/commands.shard/hermetic/test_test.dart`
verifying that `flutter test` throws a clean `ToolExit` when given a
path containing Windows reserved characters.
---------
Co-authored-by: Matthew Kosarek <[email protected]>1 parent bbc989d commit cd6955d
2 files changed
Lines changed: 48 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
794 | 794 | | |
795 | 795 | | |
796 | 796 | | |
797 | | - | |
| 797 | + | |
| 798 | + | |
| 799 | + | |
| 800 | + | |
| 801 | + | |
| 802 | + | |
| 803 | + | |
| 804 | + | |
| 805 | + | |
| 806 | + | |
798 | 807 | | |
799 | 808 | | |
800 | 809 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| 15 | + | |
15 | 16 | | |
16 | 17 | | |
17 | 18 | | |
| |||
54 | 55 | | |
55 | 56 | | |
56 | 57 | | |
| 58 | + | |
57 | 59 | | |
58 | 60 | | |
59 | 61 | | |
| |||
1809 | 1811 | | |
1810 | 1812 | | |
1811 | 1813 | | |
| 1814 | + | |
| 1815 | + | |
| 1816 | + | |
| 1817 | + | |
| 1818 | + | |
| 1819 | + | |
| 1820 | + | |
| 1821 | + | |
| 1822 | + | |
| 1823 | + | |
| 1824 | + | |
| 1825 | + | |
| 1826 | + | |
| 1827 | + | |
| 1828 | + | |
| 1829 | + | |
| 1830 | + | |
| 1831 | + | |
| 1832 | + | |
| 1833 | + | |
| 1834 | + | |
| 1835 | + | |
| 1836 | + | |
| 1837 | + | |
| 1838 | + | |
| 1839 | + | |
| 1840 | + | |
| 1841 | + | |
| 1842 | + | |
| 1843 | + | |
| 1844 | + | |
| 1845 | + | |
| 1846 | + | |
| 1847 | + | |
| 1848 | + | |
| 1849 | + | |
1812 | 1850 | | |
1813 | 1851 | | |
1814 | 1852 | | |
| |||
0 commit comments