Add with support for Optional values#2386
Merged
Gabriella439 merged 7 commits intomasterfrom Feb 19, 2022
Merged
Conversation
sjakobi
reviewed
Feb 17, 2022
Collaborator
sjakobi
left a comment
sjakobi
left a comment
There was a problem hiding this comment.
I suspect that some generator in our QuickCheck tests should be updated to produce the special ? label.
… as suggested by @sjakobi This also fixes a few bugs along the way
… as caught by @sjakobi Co-authored-by: Simon Jakobi <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… as standardized in dhall-lang/dhall-lang#1254
This completes the work initially submitted in #2373