Implement new showConstructor keyword#2372
Closed
darichey wants to merge 1 commit intodhall-lang:masterfrom
Closed
Implement new showConstructor keyword#2372darichey wants to merge 1 commit intodhall-lang:masterfrom
showConstructor keyword#2372darichey wants to merge 1 commit intodhall-lang:masterfrom
Conversation
Collaborator
|
The tests should work after merging in I just wanted to check if you needed help completing this. I can put up a PR of my own if you're busy |
Contributor
Author
|
Hi, yes, sorry about that. I would definitely appreciate any help on this and #2373. Since the start of the semester, I haven't had time to work on either. Please feel free to push directly to my branch or close these PRs and open new ones! |
Collaborator
|
@darichey: You can collect the $300 reward for completing this. If you submit the expense here then I'll approve it: https://opencollective.com/dhall/expenses/new |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently missing proper error message and updating the Arbitrary instance in Dhall.Test.QuickCheck.
Ref: dhall-lang/dhall-lang#1257