Update stream framework with new alternate keyToList function#2211
Merged
ryanfoxtyler merged 11 commits intomainfrom Jul 15, 2025
Merged
Update stream framework with new alternate keyToList function#2211ryanfoxtyler merged 11 commits intomainfrom
ryanfoxtyler merged 11 commits intomainfrom
Conversation
ghost
self-requested a review
Contributor
mangalaman93
left a comment
mangalaman93
left a comment
There was a problem hiding this comment.
We should add a test as well and considering getting rid of the boolean field that decides what function to use. We can simply check whether a field is nil.
| // | ||
| // Note: Calls to KeyToList are concurrent. | ||
| KeyToList func(key []byte, itr *Iterator) (*pb.KVList, error) | ||
| // UseKeyToListWithThreadId is used to indicate that KeyToListWithThreadId should be used |
Contributor
There was a problem hiding this comment.
This comment needs to be simplified.
| if kvs, err := st.FinishThread(threadId); err != nil { | ||
| return err | ||
| } else { | ||
| for _, kv := range kvs.Kv { |
Contributor
There was a problem hiding this comment.
we should define this as a default function and assign it to FinishThread
| var list *pb.KVList | ||
| var err error | ||
| if st.UseKeyToListWithThreadId { | ||
| list, err = st.KeyToListWithThreadId(item.KeyCopy(nil), itr, threadId) |
Contributor
There was a problem hiding this comment.
what's the benefit of passing the threadId?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.