@mangalaman93 the test error seems related to the use of t.Cleanup, can you advise?

@mangalaman93 the test error seems related to the use of t.Cleanup, can you advise?

        defer removeDir(dir)
	deletionsThreshold := 10
	mf, m, err := helpOpenOrCreateManifestFile(dir, false, 0, deletionsThreshold)

	db, err := Open(DefaultOptions(dir))
	require.NoError(t, err, "error while opening db")

	t.Cleanup(func() {
		require.NoError(t, db.Close())
	})

it seems that defer cleaned up the directory and db.Close is not happy about it. I think we should use either t.Cleanup everywhere in this test or defer.

I went back to defer for now to have control over their order, lets see if the tests now pass

and again, with the remove explicitly in the same defer as close db (since they are coupled anyway)

Thank you for the PR @RJKeevil

Thanks for the help @mangalaman93 !