chore(deps): Migrate from OpenCensus to OpenTelemetry#2169
Merged
ryanfoxtyler merged 11 commits intodgraph-io:mainfrom Feb 17, 2025
Merged
chore(deps): Migrate from OpenCensus to OpenTelemetry#2169ryanfoxtyler merged 11 commits intodgraph-io:mainfrom
ryanfoxtyler merged 11 commits intodgraph-io:mainfrom
Conversation
This was referenced Feb 13, 2025
Contributor
Author
|
Not sure how to address the issue with protobuf, could it be that |
|
About the Go version, I see #2125 downgraded it from 1.23 to 1.21. Even if the repo goes with the last N-2 versions as opposed to the Go release policy of N-1 that would still be valid to bump it to 1.22 now. Let's wait for a maintainer's input on this. |
Contributor
|
We have upgraded the Min Go version to 1.22 here #2171. Please upgrade the opentelemetry to the latest and we would be happy to merge the PR. Thank you for creating the PR. |
Contributor
Author
|
OTel dependencies upgraded. |
Contributor
mangalaman93
left a comment
mangalaman93
left a comment
There was a problem hiding this comment.
Minor spelling mistake! LGTM otherwise. @harshil-goel for final review before merge.
mangalaman93
requested changes
Feb 17, 2025
mangalaman93
approved these changes
Feb 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Migrate from OpenCensus to OpenTelemetry, doing some adjustements where there is no 1:1 migration path:
zpageshandler explicitly added tohttp.DefaultServeMux, aszpages.Handle()is not available anymore.I am also adjusting some uses of spans in compactions, so their annotations are not overwritten on every call to
runCompactDefin cases where it is called multiple times.Not using latest version of OpenTelemetry because it requires Go 1.22, and badger still supports 1.21.
Fix #2155.
Checklist
CHANGELOG.mdfile describing and linking tothis PR