Add WithChecksumVerificationMode option builder method.#1115
Merged
Add WithChecksumVerificationMode option builder method.#1115
Conversation
This was missing when options.ChecksumVerificationMode was added in #880.
danielmai
requested review from
ashish-goswami,
jarifibrahim and
manishrjain
as code owners
danielmai
commented
Nov 12, 2019
Contributor
Author
danielmai
left a comment
danielmai
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @ashish-goswami, @jarifibrahim, and @manishrjain)
campoy
approved these changes
Nov 12, 2019
Contributor
campoy
left a comment
campoy
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @ashish-goswami, @danielmai, @jarifibrahim, and @manishrjain)
options.go, line 516 at r1 (raw file):
whether
whether and when
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was missing when options.ChecksumVerificationMode was added in #880.
This change is