Makefile.am: include update-bash-completion.sh in release tarballs#91
Merged
cinderblock merged 1 commit intodfu-programmer:masterfrom Jun 15, 2023
Conversation
Commit d08f2ef (Generate bash_completion file with make, not bootstrap) added an update-bash-completion.sh script and called it from the Makefile, but forgot to add it to EXTRA_DIST, so it is not present in the release tarballs, breaking the build. Signed-off-by: Peter Korsgaard <[email protected]>
Member
|
Thank you for this. I'm slightly unhappy that we use two separate files to achieve this goal - this manual canning of the C sources to extract a list of supported targets works but feels a little kludgey to me. I suspect there is a better way. Merging for now. |
cinderblock
approved these changes
Jun 15, 2023
arnout
pushed a commit
to buildroot/buildroot
that referenced
this pull request
Oct 28, 2023
The update-bash-completion.sh issue is now fixed, so remove the workaround: dfu-programmer/dfu-programmer#91 Signed-off-by: Peter Korsgaard <[email protected]> Signed-off-by: Yann E. MORIN <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit d08f2ef (Generate bash_completion file with make, not bootstrap) added an update-bash-completion.sh script and called it from the Makefile, but forgot to add it to EXTRA_DIST, so it is not present in the release tarballs, breaking the build.