Replace inconsistent norm threshold with explicit zero check#326
Merged
marvinfriede merged 2 commits intofix-fp-underflowfrom Dec 9, 2025
Merged
Replace inconsistent norm threshold with explicit zero check#326marvinfriede merged 2 commits intofix-fp-underflowfrom
marvinfriede merged 2 commits intofix-fp-underflowfrom
Conversation
Co-authored-by: marvinfriede <[email protected]>
Copilot
AI
changed the title
[WIP] Address feedback on FP underflow guard implementation
Replace inconsistent norm threshold with explicit zero check
Dec 9, 2025
marvinfriede
approved these changes
Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses review feedback on #324 regarding the
norm < 1e-7_wpthreshold being inconsistent witheps_norm(~1e-154 for double precision).After the norm inversion guard,
normis either 0.0 or an inverted value (1.0/norm). The conditionnorm < 1e-7_wponly catches the zero case, making it redundant.Changes:
norm < 1e-7_wpwithnorm == 0.0_wpin d4.f90 (lines 302, 320)norm < 1e-7_wpwithnorm == 0.0_wpin d4s.f90 (lines 304, 317)💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.