Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR pins GCC 14 on macOS runners to avoid compilation errors introduced with GCC 15 and updates the workflows accordingly.
- Bump
cibuildwheelversion and refine macOS build steps to ensure only GCC 14 and matching OpenBLAS are present - Add cleanup of conflicting libraries, adjust environment variables, and introduce a debug delocate command
- Update Fortran build workflow to use
brew --prefixfor creating symlinks and setting flags
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/wheel.yml | Pin cibuildwheel, install GCC 14 & OpenBLAS 0.3.23, remove conflicting libs, update LDFLAGS/CPPFLAGS, add repair command |
| .github/workflows/fortran-build.yml | Use brew --prefix for symlinks to gcc/gfortran/g++, and standardize env var paths |
Comments suppressed due to low confidence (2)
.github/workflows/wheel.yml:175
- Hardcoded
/usr/local/libpath may not match Homebrew's prefix on Apple Silicon or other runner configurations. Consider using$(brew --prefix gcc@14)/libor$(brew --prefix)/libfor portability.
rm -f /usr/local/lib/libgfortran*.dylib
.github/workflows/wheel.yml:181
- After installing the versioned formula
[email protected], referencing the unversionedbrew --prefix openblasmay not resolve correctly. Usebrew --prefix [email protected]to match the installed formula.
PKG_CONFIG_PATH="$(brew --prefix openblas)/lib/pkgconfig"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pins GCC 14 to avoid reported compilation errors with GCC 15. See grimme-lab/mctc-lib#83.