fix accessing parameters in windows#292
Merged
marvinfriede merged 5 commits intodftd4:mainfrom Apr 19, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #292 +/- ##
===========================================
+ Coverage 41.13% 56.78% +15.64%
===========================================
Files 33 50 +17
Lines 2966 4357 +1391
Branches 1347 1590 +243
===========================================
+ Hits 1220 2474 +1254
+ Misses 1005 846 -159
- Partials 741 1037 +296 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Thanks for fixing. I restarted the timed out test manually. Now everything passed. |
marvinfriede
approved these changes
Apr 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Windows fix #268 has a small typo that produces confusing results :-)
All the tests really do pass (see 84e3c1b). I'm having trouble getting them all passing at once.