Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #265 +/- ##
===========================================
+ Coverage 41.13% 52.69% +11.56%
===========================================
Files 33 37 +4
Lines 2966 3507 +541
Branches 1347 1570 +223
===========================================
+ Hits 1220 1848 +628
+ Misses 1005 660 -345
- Partials 741 999 +258 ☔ View full report in Codecov by Sentry. |
marvinfriede
reviewed
Nov 6, 2024
awvwgk
reviewed
Nov 6, 2024
awvwgk
reviewed
Nov 6, 2024
marvinfriede
approved these changes
Nov 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I updated the CI comparably to the tblite based fully on pip. I removed also the build and python yamls for micomamba.
Now the full CI including coverage and wheels works again.