Fix passing atomic numbers from PySCF to D4 interface#248
Merged
marvinfriede merged 2 commits intomainfrom Jul 28, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #248 +/- ##
=======================================
Coverage 41.13% 41.13%
=======================================
Files 33 33
Lines 2966 2966
Branches 1347 1347
=======================================
Hits 1220 1220
Misses 1005 1005
Partials 741 741 ☔ View full report in Codecov by Sentry. |
awvwgk
requested changes
Jul 26, 2024
awvwgk
reviewed
Jul 26, 2024
Member
|
This PR contains many unrelated changes, please separate them into individual PRs which will be much quicker to review |
marvinfriede
force-pushed
the
fix-pyscf-charges
branch
from
81e4b1f to
a8c9e14
Compare
Member
Author
marvinfriede
force-pushed
the
fix-pyscf-charges
branch
from
a8c9e14 to
27eadca
Compare
awvwgk
approved these changes
Jul 28, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.