Merged
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #234 +/- ##
==========================================
+ Coverage 40.94% 41.16% +0.21%
==========================================
Files 33 33
Lines 2955 2964 +9
Branches 1342 1345 +3
==========================================
+ Hits 1210 1220 +10
+ Misses 1013 1005 -8
- Partials 732 739 +7 ☔ View full report in Codecov by Sentry. |
awvwgk
requested changes
Jan 22, 2024
Member
awvwgk
left a comment
awvwgk
left a comment
There was a problem hiding this comment.
Can we have a new unit test for the libxc names?
Member
Author
Sure. |
marvinfriede
force-pushed
the
libxc-names
branch
from
8f19b62 to
862f2d5
Compare
awvwgk
approved these changes
Jan 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.