Skip to content

Release version 3.7.0#231

Merged
awvwgk merged 2 commits intodftd4:mainfrom
awvwgk:release-3.7.0
Aug 29, 2024
Merged

Release version 3.7.0#231
awvwgk merged 2 commits intodftd4:mainfrom
awvwgk:release-3.7.0

Conversation

@awvwgk
Copy link
Copy Markdown
Member

@awvwgk awvwgk commented Jan 3, 2024

Probably needs to wait for #225

Closes #255

@awvwgk awvwgk requested a review from marvinfriede January 3, 2024 08:37
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c18bb6d) 41.06% compared to head (a5e4aae) 41.06%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #231   +/-   ##
=======================================
  Coverage   41.06%   41.06%           
=======================================
  Files          33       33           
  Lines        2920     2920           
  Branches     1318     1318           
=======================================
  Hits         1199     1199           
  Misses       1013     1013           
  Partials      708      708           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marvinfriede
Copy link
Copy Markdown
Member

Probably needs to wait for #225

Agreed. We also planned to wait for the publication of the actinide paper until we make an "official" new release.

@awvwgk
Copy link
Copy Markdown
Member Author

awvwgk commented Jan 3, 2024

If the paper publication is blocking a minor version release, I would insist on creating patch release by cherry-picking the bugfix for pyscf.

@marvinfriede
Copy link
Copy Markdown
Member

The paper should not take too long (definitely January), and we could also release after submission. But if the release of the PySCF patch is urgent, I am fine with your suggestion.

Copy link
Copy Markdown
Member

@marvinfriede marvinfriede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update: Apparently, there is an error in the actinide parametrization, which requires fixing.

@aizvorski
Copy link
Copy Markdown
Contributor

aizvorski commented Aug 29, 2024

Hello @awvwgk - Looking things over, it seems with #225, #220, #248 and #254, we have some really nice features and a couple of important bugfixes, it would be good to do a new release. Do you have anything in mind that needs to be done before a release? Is there anything I can help with?

@awvwgk awvwgk merged commit 7b2ff85 into dftd4:main Aug 29, 2024
@awvwgk awvwgk deleted the release-3.7.0 branch August 29, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gfortran 11.4 cannot compile - /usr/bin/ld: cannot find -lFALSE: No such file or directory

3 participants