Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #231 +/- ##
=======================================
Coverage 41.06% 41.06%
=======================================
Files 33 33
Lines 2920 2920
Branches 1318 1318
=======================================
Hits 1199 1199
Misses 1013 1013
Partials 708 708 ☔ View full report in Codecov by Sentry. |
Member
Agreed. We also planned to wait for the publication of the actinide paper until we make an "official" new release. |
Member
Author
|
If the paper publication is blocking a minor version release, I would insist on creating patch release by cherry-picking the bugfix for pyscf. |
Member
|
The paper should not take too long (definitely January), and we could also release after submission. But if the release of the PySCF patch is urgent, I am fine with your suggestion. |
marvinfriede
requested changes
Jan 12, 2024
marvinfriede
approved these changes
Jan 24, 2024
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Probably needs to wait for #225
Closes #255