Skip to content

Actinides#227

Merged
awvwgk merged 5 commits intodftd4:mainfrom
marvinfriede:actinides
Dec 11, 2023
Merged

Actinides#227
awvwgk merged 5 commits intodftd4:mainfrom
marvinfriede:actinides

Conversation

@marvinfriede
Copy link
Copy Markdown
Member

Add support for Fr, Ra and Actinides.

This PR requires the extension of the EEQ charge model to actinides from grimme-lab/multicharge#24.

@marvinfriede marvinfriede added the enhancement New feature or request label Dec 11, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 11, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (ea1311b) 41.05% compared to head (11aade6) 41.08%.
Report is 1 commits behind head on main.

Files Patch % Lines
test/unit/test_dftd4.f90 50.00% 0 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #227      +/-   ##
==========================================
+ Coverage   41.05%   41.08%   +0.03%     
==========================================
  Files          33       33              
  Lines        2906     2918      +12     
  Branches     1310     1316       +6     
==========================================
+ Hits         1193     1199       +6     
  Misses       1013     1013              
- Partials      700      706       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Member

@awvwgk awvwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now

@awvwgk awvwgk merged commit 423e7cb into dftd4:main Dec 11, 2023
@marvinfriede marvinfriede deleted the actinides branch December 21, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants