Merged
Conversation
marvinfriede
force-pushed
the
params-rsh
branch
from
6d3f4e4 to
b5b8eae
Compare
Codecov Report
@@ Coverage Diff @@
## main #220 +/- ##
==========================================
- Coverage 41.14% 41.05% -0.10%
==========================================
Files 33 33
Lines 2863 2906 +43
Branches 1287 1310 +23
==========================================
+ Hits 1178 1193 +15
- Misses 999 1013 +14
- Partials 686 700 +14
... and 1 file with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
awvwgk
requested changes
Oct 27, 2023
Member
awvwgk
left a comment
awvwgk
left a comment
There was a problem hiding this comment.
Could you also add tests for the newly added parameters?
awvwgk
reviewed
Nov 11, 2023
awvwgk
reviewed
Nov 11, 2023
awvwgk
approved these changes
Nov 13, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add parameters for the following range-separated hybrid functionals: