Replace merge statements for optional parameters#202
Merged
awvwgk merged 4 commits intodftd4:mainfrom May 14, 2023
marvinfriede:nag-fix
Merged
Replace merge statements for optional parameters#202awvwgk merged 4 commits intodftd4:mainfrom marvinfriede:nag-fix
awvwgk merged 4 commits intodftd4:mainfrom
marvinfriede:nag-fix
Conversation
Codecov Report
@@ Coverage Diff @@
## main #202 +/- ##
==========================================
+ Coverage 42.81% 42.87% +0.05%
==========================================
Files 31 31
Lines 2639 2652 +13
Branches 1095 1096 +1
==========================================
+ Hits 1130 1137 +7
- Misses 971 977 +6
Partials 538 538
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
e-kwsm
reviewed
May 4, 2023
Co-authored-by: Eisuke Kawashima <[email protected]>
awvwgk
requested changes
May 4, 2023
awvwgk
approved these changes
May 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applying the suggestions from #201.