Add command line option for functional listing#200
Add command line option for functional listing#200marvinfriede wants to merge 11 commits intodftd4:mainfrom marvinfriede:list-funcs
Conversation
Codecov Report
@@ Coverage Diff @@
## main #200 +/- ##
==========================================
- Coverage 42.87% 41.14% -1.73%
==========================================
Files 31 33 +2
Lines 2652 2863 +211
Branches 1096 1287 +191
==========================================
+ Hits 1137 1178 +41
- Misses 977 999 +22
- Partials 538 686 +148
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
awvwgk
left a comment
awvwgk
left a comment
There was a problem hiding this comment.
I would recommend to create a new subcommands like in s-dftd3 for handling the parameters. The current solution is also prone to show duplicates by listing all aliases, which should be pruned or at least somehow grouped.
Something like this? dftd4 param --listWhy should we hide the aliases? |
src/dftd4/param.f90
Outdated
| type functional_group | ||
| character(len=:), allocatable :: names(:) | ||
| contains | ||
| procedure :: set_names |
There was a problem hiding this comment.
This could be done in a more functional way using a constructor.
src/dftd4/param.f90
Outdated
| contains | ||
|
|
||
| subroutine set_names(self, input_names) | ||
| class(functional_group), intent(inout) :: self |
There was a problem hiding this comment.
This could be safely using type instead of class and out instead of inout for the intent.
|
By running -b973c
-b97_1
-b97_2
-b98
-bmk
-hcth120
-hcth407
-hf3c
-hf3cv
-hiss
-lcwhpbe
-lcwpbe
-m05
-m052x
-m062x
-m08hx
-m11l
-mn12l
-mpw1kcis
-mpwkcis1k
-n12
-n12sx
-otpss
-pbe1kcis
-pbeh1pbe
-pbeh3c
-pbehpbe
-pbexalpha
-pkzb
-ptpss
-pwb6k
-pwgga
-revssb
-sogga11x
-ssb
-tauhcthhyb
-thcth
-tpss1kcis |
3 participants
Show functionals with
or
Closes #199.