Skip to content

Delay creation of API object to avoid memory leak#196

Merged
TyBalduf merged 1 commit intodftd4:mainfrom
awvwgk:api-dealloc
Mar 2, 2023
Merged

Delay creation of API object to avoid memory leak#196
TyBalduf merged 1 commit intodftd4:mainfrom
awvwgk:api-dealloc

Conversation

@awvwgk
Copy link
Copy Markdown
Member

@awvwgk awvwgk commented Mar 1, 2023

Closes #195

@awvwgk awvwgk added bug Something isn't working API Affects the C-binding layer. labels Mar 1, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 1, 2023

Codecov Report

Merging #196 (111e486) into main (c31218f) will increase coverage by 0.00%.
The diff coverage is 20.00%.

@@           Coverage Diff           @@
##             main     #196   +/-   ##
=======================================
  Coverage   42.79%   42.79%           
=======================================
  Files          31       31           
  Lines        2636     2638    +2     
  Branches     1094     1095    +1     
=======================================
+ Hits         1128     1129    +1     
  Misses        971      971           
- Partials      537      538    +1     
Impacted Files Coverage Δ
src/dftd4/api.f90 45.18% <20.00%> (+0.03%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@awvwgk awvwgk changed the title Destroy API object in case of error Delay creation of API object to avoid memory leak Mar 1, 2023
@awvwgk awvwgk requested a review from TyBalduf March 2, 2023 13:45
Copy link
Copy Markdown
Collaborator

@TyBalduf TyBalduf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting together the pull request!

@TyBalduf TyBalduf merged commit 98a3555 into dftd4:main Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API Affects the C-binding layer. bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Small memory leak for load_rational_damping_api

2 participants