Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #194 +/- ##
===========================================
- Coverage 59.60% 42.44% -17.16%
===========================================
Files 46 31 -15
Lines 3307 2554 -753
Branches 1057 1047 -10
===========================================
- Hits 1971 1084 -887
- Misses 725 957 +232
+ Partials 611 513 -98
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
awvwgk
force-pushed
the
ci
branch
2 times, most recently
from
45d9a59 to
13fef78
Compare
Member
|
I also fixed the macos build (see here). |
Member
Author
|
The CI breakage over time is quite annoying, I found that repairing it in dftd3/simple-dftd3 was far easier than here. Therefore, I copied over the CI from there and adapted it to match the additional requirements (BLAS/Lapack). Feel free to decide which variant you prefer. |
marvinfriede
approved these changes
Feb 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using conda environments to provision the dependencies for CI testing seems more stable than using the base images.