Skip to content

Allow passing through values for dispersion model#184

Merged
awvwgk merged 1 commit intodftd4:mainfrom
awvwgk:qcsk-3c
Dec 30, 2022
Merged

Allow passing through values for dispersion model#184
awvwgk merged 1 commit intodftd4:mainfrom
awvwgk:qcsk-3c

Conversation

@awvwgk
Copy link
Copy Markdown
Member

@awvwgk awvwgk commented Dec 30, 2022

@hokru This should allow to evaluate r²SCAN-3c via qcng.

See psi4/psi4#2121

@awvwgk awvwgk added the Python Affects the Python side of this project label Dec 30, 2022
@awvwgk awvwgk mentioned this pull request Dec 30, 2022
4 tasks
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 30, 2022

Codecov Report

Merging #184 (8dd70fa) into main (3e4ea97) will decrease coverage by 0.51%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #184      +/-   ##
==========================================
- Coverage   60.12%   59.61%   -0.52%     
==========================================
  Files          44       46       +2     
  Lines        3130     3241     +111     
  Branches     1019     1055      +36     
==========================================
+ Hits         1882     1932      +50     
- Misses        667      705      +38     
- Partials      581      604      +23     
Impacted Files Coverage Δ
python/dftd4/qcschema.py 96.55% <100.00%> (+0.06%) ⬆️
python/dftd4/test_qcschema.py 93.90% <100.00%> (+0.84%) ⬆️
src/dftd4/output.f90 50.00% <0.00%> (-1.40%) ⬇️
app/driver.f90 41.17% <0.00%> (-0.41%) ⬇️
app/cli.f90 57.14% <0.00%> (-0.41%) ⬇️
src/dftd4/api.f90 40.53% <0.00%> (-0.15%) ⬇️
src/dftd4/disp.f90 64.10% <0.00%> (ø)
src/dftd4/model.f90 79.52% <0.00%> (ø)
src/dftd4/param.f90 38.22% <0.00%> (ø)
src/dftd4/utils.f90 50.00% <0.00%> (ø)
... and 12 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@awvwgk awvwgk merged commit 3035fe1 into dftd4:main Dec 30, 2022
@awvwgk awvwgk deleted the qcsk-3c branch December 30, 2022 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Python Affects the Python side of this project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant